starred/fastfetch
1
0
Fork 0
mirror of https://github.com/fastfetch-cli/fastfetch.git synced 2026-09-12 09:58:03 +02:00
Code Issues Packages Projects Releases 10 Wiki Activity

Display: adds missing ffStrbufDestroy calls in ffOptionsDestroyDisplay (#2476)

Browse Source 
13 FFstrbuf fields were initialized but never destroyed, potentially
leaking memory when configured via JSON or command-line:
- barBorderLeft, barBorderRight
- barBorderLeftElapsed, barBorderRightElapsed
- barColorElapsed, barColorTotal, barColorBorder
- tempColorGreen, tempColorYellow, tempColorRed
- percentColorGreen, percentColorYellow, percentColorRed

Co-authored-by: tru3 <tru3@tru3.com>
This commit is contained in:
h4sht
2026-07-24 02:43:31 +02:00
committed by Carter Li
parent d8ae93f85d
commit e9258cc5a8
1 changed files with 13 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/options/display.c
+13
View File
@@ -912,6 +912,19 @@ void ffOptionsDestroyDisplay(FFOptionsDisplay* options) {
ffStrbufDestroy(&options->keyValueSeparator);
ffStrbufDestroy(&options->barCharElapsed);
ffStrbufDestroy(&options->barCharTotal);
ffStrbufDestroy(&options->barBorderLeft);
ffStrbufDestroy(&options->barBorderRight);
ffStrbufDestroy(&options->barBorderLeftElapsed);
ffStrbufDestroy(&options->barBorderRightElapsed);
ffStrbufDestroy(&options->barColorElapsed);
ffStrbufDestroy(&options->barColorTotal);
ffStrbufDestroy(&options->barColorBorder);
ffStrbufDestroy(&options->tempColorGreen);
ffStrbufDestroy(&options->tempColorYellow);
ffStrbufDestroy(&options->tempColorRed);
ffStrbufDestroy(&options->percentColorGreen);
ffStrbufDestroy(&options->percentColorYellow);
ffStrbufDestroy(&options->percentColorRed);
FF_LIST_FOR_EACH (FFstrbuf, item, options->constants) {
ffStrbufDestroy(item);
}