From e9258cc5a8b34ca6774a81c680a71a0287b27545 Mon Sep 17 00:00:00 2001 From: h4sht Date: Fri, 24 Jul 2026 02:43:31 +0200 Subject: [PATCH] Display: adds missing ffStrbufDestroy calls in ffOptionsDestroyDisplay (#2476) 13 FFstrbuf fields were initialized but never destroyed, potentially leaking memory when configured via JSON or command-line: - barBorderLeft, barBorderRight - barBorderLeftElapsed, barBorderRightElapsed - barColorElapsed, barColorTotal, barColorBorder - tempColorGreen, tempColorYellow, tempColorRed - percentColorGreen, percentColorYellow, percentColorRed Co-authored-by: tru3 --- src/options/display.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/src/options/display.c b/src/options/display.c index 90418de11..6f0b19006 100644 --- a/src/options/display.c +++ b/src/options/display.c @@ -912,6 +912,19 @@ void ffOptionsDestroyDisplay(FFOptionsDisplay* options) { ffStrbufDestroy(&options->keyValueSeparator); ffStrbufDestroy(&options->barCharElapsed); ffStrbufDestroy(&options->barCharTotal); + ffStrbufDestroy(&options->barBorderLeft); + ffStrbufDestroy(&options->barBorderRight); + ffStrbufDestroy(&options->barBorderLeftElapsed); + ffStrbufDestroy(&options->barBorderRightElapsed); + ffStrbufDestroy(&options->barColorElapsed); + ffStrbufDestroy(&options->barColorTotal); + ffStrbufDestroy(&options->barColorBorder); + ffStrbufDestroy(&options->tempColorGreen); + ffStrbufDestroy(&options->tempColorYellow); + ffStrbufDestroy(&options->tempColorRed); + ffStrbufDestroy(&options->percentColorGreen); + ffStrbufDestroy(&options->percentColorYellow); + ffStrbufDestroy(&options->percentColorRed); FF_LIST_FOR_EACH (FFstrbuf, item, options->constants) { ffStrbufDestroy(item); }