Common: add on_scope_exit utility for scope-based resource management

src/common/windows/util.hpp

@@ -0,0 +1,19 @@
+#pragma once
+
+#include <utility>
+#include <type_traits>
+
+template <typename Fn>
+struct on_scope_exit {
+    static_assert(std::is_nothrow_move_constructible<Fn>::value,
+                    "Fn must be nothrow move constructible");
+
+    explicit on_scope_exit(Fn &&fn) noexcept
+        : _fn(std::move(fn)) {};
+    on_scope_exit(const on_scope_exit&) = delete;
+    on_scope_exit& operator=(const on_scope_exit&) = delete;
+    ~on_scope_exit() noexcept { this->_fn(); }
+
+private:
+    Fn _fn;
+};

src/detection/bluetooth/bluetooth_windows.cpp

@@ -4,18 +4,10 @@ extern "C"
 }
 #include "common/windows/wmi.hpp"
 #include "common/windows/unicode.hpp"
+#include "common/windows/util.hpp"
 
 STDAPI InitVariantFromStringArray(_In_reads_(cElems) PCWSTR *prgsz, _In_ ULONG cElems, _Out_ VARIANT *pvar);
 
-template <typename Fn>
-struct on_scope_exit {
-    on_scope_exit(Fn &&fn): _fn(std::move(fn)) {}
-    ~on_scope_exit() { this->_fn(); }
-
-private:
-    Fn _fn;
-};
-
 extern "C"
 const char* ffBluetoothDetectBattery(FFlist* devices)
 {

src/detection/camera/camera_windows.cpp

@@ -4,20 +4,12 @@ extern "C" {
 }
 #include "common/windows/com.hpp"
 #include "common/windows/unicode.hpp"
+#include "common/windows/util.hpp"
 
 #include <initguid.h>
 #include <mfapi.h>
 #include <mfidl.h>
 
-template <typename Fn>
-struct on_scope_exit {
-    on_scope_exit(Fn &&fn): _fn(std::move(fn)) {}
-    ~on_scope_exit() { this->_fn(); }
-
-private:
-    Fn _fn;
-};
-
 extern "C"
 const char* ffDetectCamera(FF_MAYBE_UNUSED FFlist* result)
 {

src/detection/gpu/gpu_wsl.cpp

@@ -6,6 +6,7 @@ extern "C" {
 #include "detection/gpu/gpu.h"
 #include "detection/gpu/gpu_driver_specific.h"
 }
+#include "common/windows/util.hpp"
 
 #include <wsl/winadapter.h>
 #include <directx/dxcore.h>
@@ -16,15 +17,6 @@ extern "C" {
 
 #pragma GCC diagnostic ignored "-Wmissing-field-initializers"
 
-template <typename Fn>
-struct on_scope_exit {
-    on_scope_exit(Fn &&fn): _fn(std::move(fn)) {}
-    ~on_scope_exit() { this->_fn(); }
-
-private:
-    Fn _fn;
-};
-
 extern "C"
 const char* ffGPUDetectByDirectX(FF_MAYBE_UNUSED const FFGPUOptions* options, FFlist* gpus)
 {

src/detection/wm/wm_windows.cpp

@@ -7,22 +7,13 @@ extern "C"
 }
 
 #include "common/windows/com.hpp"
+#include "common/windows/util.hpp"
 
-#include <utility>
 #include <windows.h>
 #include <tlhelp32.h>
 #include <shlobj.h>
 #include <propkey.h>
 
-template <typename Fn>
-struct on_scope_exit {
-    on_scope_exit(Fn &&fn): _fn(std::move(fn)) {}
-    ~on_scope_exit() { this->_fn(); }
-
-private:
-    Fn _fn;
-};
-
 extern "C"
 const char* ffDetectWMPlugin(FFstrbuf* pluginName)
 {