Refactored github actions

.github/workflows/check.yml

@@ -0,0 +1,48 @@
+name: run build and checks
+
+on: workflow_call
+
+jobs:
+  check:
+    name: Build, Run and Analyze fastfetch
+    runs-on: ubuntu-latest
+    permissions:
+      security-events: write
+    strategy:
+      fail-fast: false
+      matrix:
+        language: [ 'cpp' ]
+    steps:
+    - name: Checkout repository
+      uses: actions/checkout@v2
+
+    - name: Update and install packages
+      run: sudo apt-get update && sudo apt-get install -y libpci-dev libvulkan-dev libwayland-dev libxrandr-dev libxcb-randr0-dev libdconf-dev libdbus-1-dev libxfconf-0-dev librpm-dev libzstd-dev
+
+    - name: Initialize CodeQL
+      uses: github/codeql-action/init@v1
+      with:
+        languages: ${{ matrix.language }}
+
+    - name: Configure
+      # We reuse the build binary only for the releases.
+      # We set tweak version to off, because it is wrong, as git tag will happen after this step. Releases don't have a tweak, so this is ok.
+      run: cmake -DSET_TWEAK=Off .
+
+    - name: Build
+      run: cmake --build . -j$(nproc)
+
+    - name: Run fastfetch
+      run: ./fastfetch --recache --disable-linewrap false --hide-cursor false --show-errors true
+
+    - name: Run flashfetch
+      run: ./flashfetch
+
+    - name: Run tests
+      run: ctest
+
+    - name: Build deb package
+      run: sh packaging/deb/create.sh .
+
+    - name: Perform CodeQL Analysis
+      uses: github/codeql-action/analyze@v1

.github/workflows/pull_request.yml

@@ -0,0 +1,10 @@
+name: manage pull requests
+
+on: pull_request
+
+jobs:
+  manage:
+    runs-on: ubuntu-latest
+    steps:
+      - name: run build and check
+        uses: ./.github/workflows/check.yml

.github/workflows/push.yml

@@ -1,86 +1,18 @@
-name: Manage pushes and pull requests
+name: manage pushes
 
 on:
   push:
     branches: [ master ]
-  pull_request:
-    branches: [ master ]
-
-env:
-  BUILD_TYPE: Release
 
 jobs:
-  check:
-    name: Build, Run and Analyze fastfetch
-    runs-on: ubuntu-latest
-    permissions:
-      actions: read
-      contents: write
-      security-events: write
-    strategy:
-      fail-fast: false
-      matrix:
-        language: [ 'cpp' ]
-    steps:
-    - name: Checkout repository
-      uses: actions/checkout@v2
-
-    - name: Update and install packages
-      run: sudo apt-get update && sudo apt-get install -y libpci-dev libvulkan-dev libwayland-dev libxrandr-dev libxcb-randr0-dev libdconf-dev libdbus-1-dev libxfconf-0-dev librpm-dev libzstd-dev
-
-    - name: Initialize CodeQL
-      uses: github/codeql-action/init@v1
-      with:
-        languages: ${{ matrix.language }}
-
-    - name: Configure
-      run: cmake -DCMAKE_BUILD_TYPE=${{env.BUILD_TYPE}} .
-
-    - name: Build
-      run: cmake --build . -j$(nproc)
-
-    - name: Run fastfetch
-      run: ./fastfetch --recache --disable-linewrap false --hide-cursor false --show-errors true
-
-    - name: Run flashfetch
-      run: ./flashfetch
-
-    - name: Run tests
-      run: ctest
-
-    - name: Build deb package
-      run: sh packaging/deb/create.sh .
-
-    - name: Perform CodeQL Analysis
-      uses: github/codeql-action/analyze@v1
-
-    - name: Create tarball
-      if: github.event_name == 'push'
-      run: tar -cvf fastfetch.tar ./fastfetch -C packaging/deb ./fastfetch.deb
-
-    - name: Upload tarball
-      if: github.event_name == 'push'
-      uses: actions/upload-artifact@v3
-      with:
-        name: fastfetch.tar
-        path: ./fastfetch.tar
-
-  deploy:
+  manage:
     name: Create GitHub release
     runs-on: ubuntu-latest
-    needs: check
-    if: github.event_name == 'push'
     permissions:
       contents: write
     steps:
-      - name: Download tarball
-        uses: actions/download-artifact@v3
-        with:
-          name: fastfetch.tar
-          path: ./fastfetch.tar
-
-      - name: Extract tarball
-        run: tar --overwrite -xvf ./fastfetch.tar/fastfetch.tar
+      - name: run build and check
+        uses: ./.github/workflows/check.yml
 
       - name: Get fastfetch version
         id: get_version_fastfetch
@@ -98,4 +30,4 @@ jobs:
         with:
           tag: ${{ steps.get_version_fastfetch.outputs.release }}
           commit: ${{ github.sha }}
-          artifacts: ./fastfetch,./fastfetch.deb
+          artifacts: ./fastfetch,./packaging/deb/fastfetch.deb

CMakeLists.txt

@@ -5,9 +5,12 @@ project(fastfetch
     LANGUAGES C
 )
 
+# This is used by github actions for release builds
+OPTION(SET_TWEAK "Add tweak to project version" ON)
+
 # Track commits between version bumps for output in --version
 # Ignored by --version-raw and github actions
-if (EXISTS "${CMAKE_SOURCE_DIR}/.git")
+if (SET_TWEAK AND EXISTS "${CMAKE_SOURCE_DIR}/.git")
     execute_process(
         COMMAND git describe --tags
         WORKING_DIRECTORY "${CMAKE_SOURCE_DIR}"