Title: fix typo fdqn -> fqdn; support standard module args

This commit is contained in:
李通洲
2023-07-05 15:47:47 +08:00
parent 7bd9e1e750
commit 5e9f850fe1
4 changed files with 42 additions and 16 deletions
+9
View File
@@ -965,6 +965,15 @@
"type": "boolean",
"title": "Set if the title should use fully qualified domain name",
"default": false
},
"key": {
"$ref": "#/$defs/key"
},
"keyColor": {
"$ref": "#/$defs/keyColor"
},
"format": {
"$ref": "#/$defs/format"
}
},
"additionalProperties": false
+1 -1
View File
@@ -9,7 +9,7 @@ void ffPrintSeparator(FFSeparatorOptions* options)
if (titleLength == 0)
{
// Title was not printed, should we support this case?
titleLength = instance.state.platform.userName.length + 1 + (instance.config.title.fdqn ?
titleLength = instance.state.platform.userName.length + 1 + (instance.config.title.fqdn ?
instance.state.platform.domainName.length :
instance.state.platform.hostName.length
);
+2 -1
View File
@@ -7,6 +7,7 @@
typedef struct FFTitleOptions
{
const char* moduleName;
FFModuleArgs moduleArgs;
bool fdqn;
bool fqdn;
} FFTitleOptions;
+30 -14
View File
@@ -4,6 +4,8 @@
#include "util/textModifier.h"
#include "util/stringUtils.h"
#define FF_TITLE_NUM_FORMAT_ARGS 2
static inline void printTitlePart(const FFstrbuf* content)
{
if(!instance.config.pipe)
@@ -20,34 +22,45 @@ static inline void printTitlePart(const FFstrbuf* content)
void ffPrintTitle(FFTitleOptions* options)
{
ffLogoPrintLine();
printTitlePart(&instance.state.platform.userName);
putchar('@');
FFstrbuf* host = options->fdqn ?
FFstrbuf* host = options->fqdn ?
&instance.state.platform.domainName :
&instance.state.platform.hostName;
printTitlePart(host);
if (options->moduleArgs.outputFormat.length == 0)
{
ffPrintLogoAndKey(options->moduleArgs.key.length == 0 ? NULL : FF_TITLE_MODULE_NAME, 0, &options->moduleArgs.key, &options->moduleArgs.keyColor);
printTitlePart(&instance.state.platform.userName);
putchar('@');
printTitlePart(host);
putchar('\n');
}
else
{
ffPrintFormat(FF_TITLE_MODULE_NAME, 0, &options->moduleArgs, FF_TITLE_NUM_FORMAT_ARGS, (FFformatarg[]){
{FF_FORMAT_ARG_TYPE_STRBUF, &instance.state.platform.userName},
{FF_FORMAT_ARG_TYPE_STRBUF, host},
});
}
instance.state.titleLength = instance.state.platform.userName.length + host->length + 1;
putchar('\n');
}
void ffInitTitleOptions(FFTitleOptions* options)
{
options->moduleName = FF_TITLE_MODULE_NAME;
options->fdqn = false;
ffOptionInitModuleArg(&options->moduleArgs);
options->fqdn = false;
}
bool ffParseTitleCommandOptions(FFTitleOptions* options, const char* key, const char* value)
{
const char* subKey = ffOptionTestPrefix(key, FF_TITLE_MODULE_NAME);
if (!subKey) return false;
if (ffOptionParseModuleArgs(key, subKey, value, &options->moduleArgs))
return true;
if (ffStrEqualsIgnCase(subKey, "fdqn"))
if (ffStrEqualsIgnCase(subKey, "fqdn"))
{
options->fdqn = ffOptionParseBoolean(value);
options->fqdn = ffOptionParseBoolean(value);
return true;
}
@@ -56,7 +69,7 @@ bool ffParseTitleCommandOptions(FFTitleOptions* options, const char* key, const
void ffDestroyTitleOptions(FFTitleOptions* options)
{
FF_UNUSED(options);
ffOptionDestroyModuleArg(&options->moduleArgs);
}
void ffParseTitleJsonObject(yyjson_val* module)
@@ -74,9 +87,12 @@ void ffParseTitleJsonObject(yyjson_val* module)
if(ffStrEqualsIgnCase(key, "type"))
continue;
if (ffStrEqualsIgnCase(key, "fdqn"))
if (ffJsonConfigParseModuleArgs(key, val, &options.moduleArgs))
continue;
if (ffStrEqualsIgnCase(key, "fqdn"))
{
options.fdqn = yyjson_get_bool(val);
options.fqdn = yyjson_get_bool(val);
continue;
}