fastfetch-cli/fastfetch
1
0
Fork 0
mirror of https://github.com/fastfetch-cli/fastfetch.git synced 2026-09-13 02:42:09 +02:00
Code Issues Packages Projects Releases 10 Wiki Activity

Settings: fixes DBusMessage reply leaks in XFConf functions

Browse Source 
Co-authored-by: Copilot <copilot@github.com>
This commit is contained in:
Carter Li
2026-04-30 09:01:16 +08:00
parent e694c8ac84
commit 3d6bffe7fe
1 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/common/impl/settings.c
+7
View File
@@ -225,6 +225,7 @@ FFvariant ffSettingsGetXFConf(const char* channelName, const char* propertyName,
dbus.lib->ffdbus_message_unref(reply);
return (FFvariant) { .intValue = value };
}
dbus.lib->ffdbus_message_unref(reply);
return FF_VARIANT_NULL;
}
@@ -234,6 +235,7 @@ FFvariant ffSettingsGetXFConf(const char* channelName, const char* propertyName,
dbus.lib->ffdbus_message_unref(reply);
return (FFvariant) { .strValue = value.chars }; // Leaks value.chars
}
dbus.lib->ffdbus_message_unref(reply);
return FF_VARIANT_NULL;
}
@@ -245,6 +247,7 @@ FFvariant ffSettingsGetXFConf(const char* channelName, const char* propertyName,
}
}
dbus.lib->ffdbus_message_unref(reply);
return FF_VARIANT_NULL;
}
@@ -297,6 +300,7 @@ FFvariant ffSettingsGetXFConfFirstMatch(const char* channelName, const char* pro
dbus.lib->ffdbus_message_unref(reply);
return (FFvariant) { .intValue = value };
}
dbus.lib->ffdbus_message_unref(reply);
return FF_VARIANT_NULL;
}
@@ -306,6 +310,7 @@ FFvariant ffSettingsGetXFConfFirstMatch(const char* channelName, const char* pro
dbus.lib->ffdbus_message_unref(reply);
return (FFvariant) { .strValue = value.chars }; // Leaks value.chars
}
dbus.lib->ffdbus_message_unref(reply);
return FF_VARIANT_NULL;
}
@@ -317,9 +322,11 @@ FFvariant ffSettingsGetXFConfFirstMatch(const char* channelName, const char* pro
}
}
dbus.lib->ffdbus_message_unref(reply);
return FF_VARIANT_NULL;
}
dbus.lib->ffdbus_message_unref(reply);
return FF_VARIANT_NULL;
}
#else // FF_HAVE_DBUS