macOS: completely drop libplist dependency

.github/workflows/push.yml

@@ -64,7 +64,7 @@ jobs:
         uses: actions/checkout@v3
 
       - name: install required packages
-        run: brew install vulkan-loader libplist
+        run: brew install vulkan-loader molten-vk
 
       - name: Initialize CodeQL
         uses: github/codeql-action/init@v2

CMakeLists.txt

@@ -46,7 +46,6 @@ cmake_dependent_option(ENABLE_EGL "Enable egl" ON "LINUX OR BSD" OFF)
 cmake_dependent_option(ENABLE_GLX "Enable glx" ON "LINUX OR BSD" OFF)
 cmake_dependent_option(ENABLE_OSMESA "Enable osmesa" ON "LINUX OR BSD" OFF)
 cmake_dependent_option(ENABLE_OPENCL "Enable opencl" ON "LINUX OR BSD" OFF)
-cmake_dependent_option(ENABLE_LIBPLIST "Enable libplist" ON "APPLE" OFF)
 cmake_dependent_option(ENABLE_LIBCJSON "Enable libcjson" ON "LINUX" OFF)
 cmake_dependent_option(ENABLE_FREETYPE "Enable freetype" ON "ANDROID" OFF)
 
@@ -396,7 +395,6 @@ ff_lib_enable(EGL egl)
 ff_lib_enable(GLX glx)
 ff_lib_enable(OSMESA osmesa)
 ff_lib_enable(OPENCL OpenCL)
-ff_lib_enable(LIBPLIST libplist-2.0)
 ff_lib_enable(LIBCJSON libcjson)
 ff_lib_enable(FREETYPE freetype2)
 

README.md

@@ -44,7 +44,6 @@ The following libraries are used if present at runtime:
 * [`libXFConf`](https://gitlab.xfce.org/xfce/xfconf): Needed for XFWM theme and XFCE Terminal font.
 * [`libsqlite3`](https://www.sqlite.org/index.html): Needed for pkg & rpm package count.
 * [`librpm`](http://rpm.org/): Slower fallback for rpm package count. Needed on openSUSE.
-* [`libplist`](https://github.com/libimobiledevice/libplist): Binary `plist` file parser ( macOS ). Needed for iTerm2 Terminal font and WM Theme.
 * [`libcJSON`](https://github.com/DaveGamble/cJSON): Needed for Windows Terminal font ( WSL ).
 * [`freetype`](https://www.freetype.org/): Needed for Termux font detection ( Android ).
 

src/common/init.c

@@ -219,7 +219,6 @@ static void defaultConfig(FFinstance* instance)
     ffStrbufInitA(&instance->config.libGLX, 0);
     ffStrbufInitA(&instance->config.libOSMesa, 0);
     ffStrbufInitA(&instance->config.libOpenCL, 0);
-    ffStrbufInitA(&instance->config.libplist, 0);
     ffStrbufInitA(&instance->config.libcJSON, 0);
     ffStrbufInitA(&instance->config.libfreetype, 0);
 
@@ -482,9 +481,6 @@ void ffListFeatures()
         #ifdef FF_HAVE_OPENCL
             "opencl\n"
         #endif
-        #ifdef FF_HAVE_LIBPLIST
-            "libplist\n"
-        #endif
         #ifdef FF_HAVE_LIBCJSON
             "libcjson\n"
         #endif

src/data/config_user.txt

@@ -347,6 +347,5 @@
 #--lib-glx /usr/lib/libGLX.so
 #--lib-osmesa /usr/lib/libOSMesa.so
 #--lib-opencl /usr/lib/libOpenCL.so
-#--lib-plist /usr/local/bin/libplist-2.0.dylib
 #--lib-cjson /usr/lib/libcjson.so
 #--lib-freetype /data/data/com.termux/files/usr/lib

src/data/help.txt

@@ -84,7 +84,6 @@ Library options: Set the path of a library to load
     --lib-glx <path>
     --lib-osmesa <path>
     --lib-opencl <path>
-    --lib-plist <path>
     --lib-cjson <path>
 
 Module specific options:

src/fastfetch.c

@@ -1241,8 +1241,6 @@ static void parseOption(FFinstance* instance, FFdata* data, const char* key, con
         optionParseString(key, value, &instance->config.libOSMesa);
     else if(strcasecmp(key, "--lib-opencl") == 0)
         optionParseString(key, value, &instance->config.libOpenCL);
-    else if(strcasecmp(key, "--lib-plist") == 0)
-        optionParseString(key, value, &instance->config.libplist);
     else if(strcasecmp(key, "--lib-cjson") == 0)
         optionParseString(key, value, &instance->config.libcJSON);
 

src/fastfetch.h

@@ -151,7 +151,6 @@ typedef struct FFconfig
     FFstrbuf libGLX;
     FFstrbuf libOSMesa;
     FFstrbuf libOpenCL;
-    FFstrbuf libplist;
     FFstrbuf libcJSON;
     FFstrbuf libfreetype;