OPNsense VM: say why the EFI disk could not be allocated

pvesm's error went to stderr only, so the two exit 220 runs in telemetry
carry no reason. As msg_error it reaches the log and the trace, e.g.
"disk image '.../vm-969-disk-0.qcow2' already exists" after an earlier
run left its disk on a storage that qm destroy does not clean.

CHANGELOG.md

@@ -581,12 +581,10 @@ Exercise vigilance regarding copycat or coat-tailing sites that seek to exploit
 
 ### 💾 Core
 
-  - fix: pve-LXC: say when the container went away during its setup [@MickLesk](https://github.com/MickLesk) ([core#192](https://github.com/community-scripts/core/pull/192))
-- fix: treat Esc in a VM wizard dialog as leaving the script [@MickLesk](https://github.com/MickLesk) ([core#190](https://github.com/community-scripts/core/pull/190))
-- ref: count a container stopped during a detached install as an abort [@MickLesk](https://github.com/MickLesk) ([core#187](https://github.com/community-scripts/core/pull/187))
-- feat: find the assets of a renamed GitHub repo without the API [@MickLesk](https://github.com/MickLesk) ([core#188](https://github.com/community-scripts/core/pull/188))
+  - feat: add var_cmode to set the container console mode [@MickLesk](https://github.com/MickLesk) ([core#180](https://github.com/community-scripts/core/pull/180))
 - fix: restore npm when an interrupted update left it behind [@MickLesk](https://github.com/MickLesk) ([core#189](https://github.com/community-scripts/core/pull/189))
-- feat: add var_cmode to set the container console mode [@MickLesk](https://github.com/MickLesk) ([core#180](https://github.com/community-scripts/core/pull/180))
+- feat: find the assets of a renamed GitHub repo without the API [@MickLesk](https://github.com/MickLesk) ([core#188](https://github.com/community-scripts/core/pull/188))
+- ref: count a container stopped during a detached install as an abort [@MickLesk](https://github.com/MickLesk) ([core#187](https://github.com/community-scripts/core/pull/187))
 
 ## 2026-11-02
 

tools/addon/netdata.sh

@@ -80,7 +80,7 @@ install() {
   msg_ok "Set up repository"
 
   msg_info "Installing ${APP}"
-  apt_update_safe
+  $STD apt update
   $STD apt install -y netdata
   msg_ok "Installed ${APP}"
   msg_ok "Completed successfully!\n"
@@ -108,7 +108,7 @@ OPTIONS=(Install "Install ${APP} on Proxmox VE"
   Uninstall "Uninstall ${APP} from Proxmox VE")
 
 CHOICE=$(whiptail --backtitle "Proxmox VE Helper Scripts" --title "${APP}" \
-  --menu "Select an option:" 10 58 2 "${OPTIONS[@]}" 3>&1 1>&2 2>&3) || exit 0
+  --menu "Select an option:" 10 58 2 "${OPTIONS[@]}" 3>&1 1>&2 2>&3)
 
 case $CHOICE in
 "Install") install ;;

vm/opnsense-vm.sh

@@ -47,7 +47,7 @@ function check_disk_space() {
 }
 
 TEMP_DIR=$(mktemp -d)
-if ! check_disk_space "$TEMP_DIR" 20 && [ -d "/var/tmp" ] && check_disk_space "/var/tmp" 20; then
+if ! check_disk_space "$TEMP_DIR" 4 && [ -d "/var/tmp" ] && check_disk_space "/var/tmp" 4; then
   rm -rf "$TEMP_DIR"
   TEMP_DIR=$(mktemp -d /var/tmp/opnsense-vm.XXXXXX)
 fi
@@ -364,15 +364,6 @@ FREEBSD_VER="$VM_INDEX_LATEST"
 URL="$VM_INDEX_URL"
 msg_ok "Download URL: ${CL}${BL}${URL}${CL}"
 
-# Check available disk space (require at least 20GB for safety)
-if ! check_disk_space "$TEMP_DIR" 20; then
-  AVAILABLE_GB=$(df -h "$TEMP_DIR" | awk 'NR==2 {print $4}')
-  msg_error "Insufficient disk space in temporary directory ($TEMP_DIR)."
-  msg_error "Available: ${AVAILABLE_GB}, Required: ~20GB for FreeBSD image decompression."
-  msg_error "Please free up space or ensure /tmp has sufficient storage."
-  exit 214
-fi
-
 msg_info "Downloading FreeBSD Image"
 # A mirror serving an error page returns 200, so size decides whether this
 # is an image. Anything real here is far above 5 MB.
@@ -381,11 +372,14 @@ vm_fetch_image "$URL" "$CACHE_FILE" --cache --verify-xz --min-bytes $((5 * 1024
 echo -en "\e[1A\e[0K"
 msg_ok "Downloaded ${CL}${BL}$(basename "$CACHE_FILE")${CL}"
 
-# Check disk space again before decompression
-if ! check_disk_space "$TEMP_DIR" 15; then
+# The download sits in the image cache; only the unpacked image (2.5 GB for
+# FreeBSD 15.1, not 20) lands in TEMP_DIR, and xz knows its size up front.
+NEED_GB=$(($(xz --robot -l "$CACHE_FILE" | awk '$1 == "totals" {print $5}') / 1024 / 1024 / 1024 + 1))
+if ! check_disk_space "$TEMP_DIR" "$NEED_GB"; then
   AVAILABLE_GB=$(df -h "$TEMP_DIR" | awk 'NR==2 {print $4}')
-  msg_error "Insufficient disk space for decompression."
-  msg_error "Available: ${AVAILABLE_GB}, Required: ~15GB for decompressed image."
+  msg_error "Insufficient disk space for decompression in ${TEMP_DIR}."
+  msg_error "Available: ${AVAILABLE_GB}, Required: ~${NEED_GB}GB for the decompressed image."
+  msg_error "Please free up space or ensure /tmp or /var/tmp has sufficient storage."
   exit 214
 fi
 
@@ -417,7 +411,7 @@ while :; do
     alloc_delay=$((alloc_delay * 2))
     continue
   fi
-  echo -e "$alloc_err" >&2
+  msg_error "Could not allocate the EFI disk on ${STORAGE}: ${alloc_err}"
   exit 220
 done
 vm_import_disk "$VMID" "$FILE" "$STORAGE"