starred/return-youtube-dislike
1
0 Fork 0
mirror of https://github.com/Anarios/return-youtube-dislike.git synced 2026-11-12 17:11:30 +01:00
Code Issues 22 Packages Projects Releases Wiki Activity

[PR #1016] [MERGED] Implemented centralized versioning #358

New Issue
Closed
opened 2026-11-11 16:41:28 +01:00 by Alvin-Zilverstand · 0 comments
Alvin-Zilverstand commented 2026-11-11 16:41:28 +01:00
Owner
Copy link
Copy source

📋 Pull Request Information

Original PR: https://github.com/Anarios/return-youtube-dislike/pull/1016
Author: @Moondarker
Created: 12/13/2023
Status: ✅ Merged
Merged: 1/15/2024
Merged by: @Anarios

Base: main ← Head: centralized-versioning

📝 Commits (1)

  • 33b7358 Implemented centralized versioning

📊 Changes

21 files changed (+46 additions, -20 deletions)

View changed files

📝 Extensions/combined/_locales/cs/messages.json (+1 -1)
📝 Extensions/combined/_locales/de/messages.json (+1 -1)
📝 Extensions/combined/_locales/el/messages.json (+1 -1)
📝 Extensions/combined/_locales/en/messages.json (+1 -1)
📝 Extensions/combined/_locales/es/messages.json (+1 -1)
📝 Extensions/combined/_locales/fr/messages.json (+1 -1)
📝 Extensions/combined/_locales/it/messages.json (+1 -1)
📝 Extensions/combined/_locales/ja/messages.json (+1 -1)
📝 Extensions/combined/_locales/ko/messages.json (+1 -1)
📝 Extensions/combined/_locales/nl/messages.json (+1 -1)
📝 Extensions/combined/_locales/pl/messages.json (+1 -1)
📝 Extensions/combined/_locales/pt_BR/messages.json (+1 -1)
📝 Extensions/combined/_locales/ru/messages.json (+1 -1)
📝 Extensions/combined/_locales/sv_SE/messages.json (+1 -1)
📝 Extensions/combined/_locales/tr/messages.json (+1 -1)
📝 Extensions/combined/_locales/uk/messages.json (+1 -1)
📝 Extensions/combined/manifest-chrome.json (+1 -1)
📝 Extensions/combined/manifest-firefox.json (+1 -1)
📝 Extensions/combined/manifest-safari.json (+1 -1)
📝 package.json (+1 -1)

...and 1 more files

📄 Description

Version numbers were all over the place - different versions in localization files (3.0.0.13, and 3.0.0.1 in PL), GitHub manifest (3.0.0.12), extension stores manifest (3.0.0.14), and package.json (2.0.0).

This pull request aims to fix the problem by changing all the version references except for one in package.json to template strings. These template strings will be replaced to the actual build number from package.json at build time.

Because versioning scheme of this project is not compatible with SemVer, it looks different in package.json (e.g. 3.0.0-14 instead of 3.0.0.14), but it's converted back to the currently used versioning scheme during the build.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Anarios/return-youtube-dislike/pull/1016 **Author:** [@Moondarker](https://github.com/Moondarker) **Created:** 12/13/2023 **Status:** ✅ Merged **Merged:** 1/15/2024 **Merged by:** [@Anarios](https://github.com/Anarios) **Base:** `main` ← **Head:** `centralized-versioning` --- ### 📝 Commits (1) - [`33b7358`](https://github.com/Anarios/return-youtube-dislike/commit/33b7358496b42fad6e39c187f096656d9a032942) Implemented centralized versioning ### 📊 Changes **21 files changed** (+46 additions, -20 deletions) <details> <summary>View changed files</summary> 📝 `Extensions/combined/_locales/cs/messages.json` (+1 -1) 📝 `Extensions/combined/_locales/de/messages.json` (+1 -1) 📝 `Extensions/combined/_locales/el/messages.json` (+1 -1) 📝 `Extensions/combined/_locales/en/messages.json` (+1 -1) 📝 `Extensions/combined/_locales/es/messages.json` (+1 -1) 📝 `Extensions/combined/_locales/fr/messages.json` (+1 -1) 📝 `Extensions/combined/_locales/it/messages.json` (+1 -1) 📝 `Extensions/combined/_locales/ja/messages.json` (+1 -1) 📝 `Extensions/combined/_locales/ko/messages.json` (+1 -1) 📝 `Extensions/combined/_locales/nl/messages.json` (+1 -1) 📝 `Extensions/combined/_locales/pl/messages.json` (+1 -1) 📝 `Extensions/combined/_locales/pt_BR/messages.json` (+1 -1) 📝 `Extensions/combined/_locales/ru/messages.json` (+1 -1) 📝 `Extensions/combined/_locales/sv_SE/messages.json` (+1 -1) 📝 `Extensions/combined/_locales/tr/messages.json` (+1 -1) 📝 `Extensions/combined/_locales/uk/messages.json` (+1 -1) 📝 `Extensions/combined/manifest-chrome.json` (+1 -1) 📝 `Extensions/combined/manifest-firefox.json` (+1 -1) 📝 `Extensions/combined/manifest-safari.json` (+1 -1) 📝 `package.json` (+1 -1) _...and 1 more files_ </details> ### 📄 Description Version numbers were all over the place - different versions in localization files (`3.0.0.13`, and `3.0.0.1` in PL), GitHub manifest (`3.0.0.12`), extension stores manifest (`3.0.0.14`), and `package.json` (`2.0.0`). This pull request aims to fix the problem by changing all the version references except for one in `package.json` to template strings. These template strings will be replaced to the actual build number from `package.json` at build time. Because versioning scheme of this project is not compatible with SemVer, it looks different in `package.json` (e.g. `3.0.0-14` instead of `3.0.0.14`), but it's converted back to the currently used versioning scheme during the build. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Alvin-Zilverstand added the pull-request label 2026-11-11 16:41:28 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
accessibility
Improvements or additions regarding accessibility
 bug
Something isn't working
 dependencies
Pull requests that update a dependency file
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 github_actions
Pull requests that update GitHub Actions code
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 javascript
Pull requests that update javascript code
 pull-request
Mirrored from GitHub Pull Request
 question
Further information is requested
 todo
this needs to be done
 wontfix
This will not be worked on
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
Alvin-Zilverstand
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/return-youtube-dislike#358