[PR #1354] [MERGED] fix: disable ifconfig-pool-persist when duplicate-cn is enabled #375

New Issue

2026-11-11T16:41:27+01:00

Alvin-Zilverstand commented

2026-11-11 16:41:27 +01:00

📋 Pull Request Information

Original PR: https://github.com/angristan/openvpn-install/pull/1354
Author: @angristan
Created: 12/11/2025
Status: ✅ Merged
Merged: 12/12/2025
Merged by: @angristan

Base: master ← Head: fix/ifconfig-pool-persist-duplicate-cn

📝 Commits (1)

b65c80c fix: disable ifconfig-pool-persist when duplicate-cn is enabled

📊 Changes

2 files changed (+8 additions, -3 deletions)

View changed files

📝 README.md (+1 -1)
📝 openvpn-install.sh (+7 -2)

📄 Description

Summary

Only add ifconfig-pool-persist to server.conf when MULTI_CLIENT != y
Add note in the installation prompt about this limitation
Update README to mention the trade-off

First reported in https://github.com/angristan/openvpn-install/issues/440#issuecomment-2987417197

Background

ifconfig-pool-persist is incompatible with duplicate-cn. When duplicate-cn is enabled, OpenVPN bypasses common name matching in the IP pool allocation, making the persistence file ineffective.

From OpenVPN source:

if (o->duplicate_cn && o->ifconfig_pool_persist_filename)
{
    msg(M_WARN, "WARNING: --ifconfig-pool-persist will not work with --duplicate-cn");
}

Previously, the script always added ifconfig-pool-persist ipp.txt regardless of whether duplicate-cn was enabled via MULTI_CLIENT=y.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/angristan/openvpn-install/pull/1354 **Author:** [@angristan](https://github.com/angristan) **Created:** 12/11/2025 **Status:** ✅ Merged **Merged:** 12/12/2025 **Merged by:** [@angristan](https://github.com/angristan) **Base:** `master` ← **Head:** `fix/ifconfig-pool-persist-duplicate-cn` --- ### 📝 Commits (1) - [`b65c80c`](https://github.com/angristan/openvpn-install/commit/b65c80c59caf4056b11a037d8c6488654686aa4a) fix: disable ifconfig-pool-persist when duplicate-cn is enabled ### 📊 Changes **2 files changed** (+8 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+1 -1) 📝 `openvpn-install.sh` (+7 -2) </details> ### 📄 Description ## Summary - Only add `ifconfig-pool-persist` to server.conf when `MULTI_CLIENT != y` - Add note in the installation prompt about this limitation - Update README to mention the trade-off First reported in https://github.com/angristan/openvpn-install/issues/440#issuecomment-2987417197 ## Background `ifconfig-pool-persist` is incompatible with `duplicate-cn`. When `duplicate-cn` is enabled, OpenVPN bypasses common name matching in the IP pool allocation, making the persistence file ineffective. From [OpenVPN source](https://github.com/OpenVPN/openvpn/blob/e5ff8247/src/openvpn/init.c#L3608-L3610): ```c if (o->duplicate_cn && o->ifconfig_pool_persist_filename) { msg(M_WARN, "WARNING: --ifconfig-pool-persist will not work with --duplicate-cn"); } ``` Previously, the script always added `ifconfig-pool-persist ipp.txt` regardless of whether `duplicate-cn` was enabled via `MULTI_CLIENT=y`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

Alvin-Zilverstand added the pull-request label 2026-11-11 16:41:27 +01:00

Alvin-Zilverstand closed this issue

2026-11-11 16:41:28 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/openvpn-install#375