starred/openvpn-install
1
0 Fork 0
mirror of https://github.com/angristan/openvpn-install.git synced 2026-11-12 00:51:24 +01:00
Code Issues 13 Packages Projects Releases Wiki Activity

[PR #1243] [MERGED] Fix Public IP detection - Fix issue when seeip.org is unreachable #1241 #336

New Issue
Closed
opened 2026-11-11 16:41:14 +01:00 by Alvin-Zilverstand · 0 comments
Alvin-Zilverstand commented 2026-11-11 16:41:14 +01:00
Owner
Copy link
Copy source

📋 Pull Request Information

Original PR: https://github.com/angristan/openvpn-install/pull/1243
Author: @ralphg6
Created: 8/10/2024
Status: ✅ Merged
Merged: 11/7/2024
Merged by: @angristan

Base: master ← Head: master

📝 Commits (9)

  • d7cba3c Fix Public IP detection
  • de65f02 feat: public ip as a function
  • 5fd2237 Fix IP Detection conditions
  • 21be562 Merge pull request #1 from ralphg6/feat/public-ip-function
  • b793f53 feat: decrease failed retry number
  • 3f79f01 Merge branch 'master' into master
  • 93cd4ed ip.seeip.org -> api.seeip.org
  • 1cb0504 Fix lint issue
  • 26194f5 Fix lint

📊 Changes

1 file changed (+46 additions, -12 deletions)

View changed files

📝 openvpn-install.sh (+46 -12)

📄 Description

The script does work when seeip.org is unreachable, so I changed the policy to define the public IP.

It solves the issue #1241

CHANGELOG

Added

  • Timeout limit on each try to solve the IP to avoid long waits;
  • Extra public IP providers as failovers;

Changed

  • the script only will try to solve an IP if the ENDPOINT is empty;

Removed

  • Unneeded output of CURL commands on IP detection;
  • Duplicated code;

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/angristan/openvpn-install/pull/1243 **Author:** [@ralphg6](https://github.com/ralphg6) **Created:** 8/10/2024 **Status:** ✅ Merged **Merged:** 11/7/2024 **Merged by:** [@angristan](https://github.com/angristan) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (9) - [`d7cba3c`](https://github.com/angristan/openvpn-install/commit/d7cba3c2dca0166d9ad4536b7edcfc56e94780c6) Fix Public IP detection - [`de65f02`](https://github.com/angristan/openvpn-install/commit/de65f0299477b46b45a63d71446e2424270ae18e) feat: public ip as a function - [`5fd2237`](https://github.com/angristan/openvpn-install/commit/5fd223790d43b52c3b68e11046c6b5d286ddc3b0) Fix IP Detection conditions - [`21be562`](https://github.com/angristan/openvpn-install/commit/21be56291929eb428c28921e1cf70e5be7a55a2a) Merge pull request #1 from ralphg6/feat/public-ip-function - [`b793f53`](https://github.com/angristan/openvpn-install/commit/b793f531689fac4eaae4001b71cc7bfae5cfd64e) feat: decrease failed retry number - [`3f79f01`](https://github.com/angristan/openvpn-install/commit/3f79f01ed5adc2c6cb387d1c26379f616a79c485) Merge branch 'master' into master - [`93cd4ed`](https://github.com/angristan/openvpn-install/commit/93cd4ed0892416e6bd287e53d4cf1a7c6759575f) ip.seeip.org -> api.seeip.org - [`1cb0504`](https://github.com/angristan/openvpn-install/commit/1cb0504341cb55eaea83b36977f928d2c2ba49ae) Fix lint issue - [`26194f5`](https://github.com/angristan/openvpn-install/commit/26194f5dd5bb568a4425198b653f83a6e5f58715) Fix lint ### 📊 Changes **1 file changed** (+46 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `openvpn-install.sh` (+46 -12) </details> ### 📄 Description The script does work when seeip.org is unreachable, so I changed the policy to define the public IP. It solves the issue #1241 ## CHANGELOG ### Added - Timeout limit on each try to solve the IP to avoid long waits; - Extra public IP providers as failovers; ### Changed - the script only will try to solve an IP if the ENDPOINT is empty; ### Removed - Unneeded output of CURL commands on IP detection; - Duplicated code; --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Alvin-Zilverstand added the pull-request label 2026-11-11 16:41:14 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
abandoned
bug
bug fix
censorship
ci-fail
dependencies
Pull requests that update a dependency file
 docs
documentation
duplicate
enhancement
feature
feature-request
help wanted
invalid
need feedback
need info
need-rebase
need-rework
out-of-scope
pull-request
Mirrored from GitHub Pull Request
 support
to-test
wontfix
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
Alvin-Zilverstand
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/openvpn-install#336