mirror of
https://github.com/Alvin-Zilverstand/bob16.git
synced 2026-11-21 12:52:59 +01:00
Expand Bob64 widget interaction coverage
This commit is contained in:
1 parent
9794f6c156
commit
a36f080ded
5 files changed
+115
-14
No files matched your search
@@ -0,0 +1,17 @@
|
|||||||
|
# AI Agent Communication Files
|
||||||
|
|
||||||
|
This index lists the repository files used for coordination between Codex and OpenCode.
|
||||||
|
|
||||||
|
## Shared coordination
|
||||||
|
|
||||||
|
- [`OPENCODE_COORDINATION.md`](OPENCODE_COORDINATION.md) — Current shared task protocol, task ownership, OpenCode's Bob64 unsigned-integer analysis, widget-coverage review, test status, and overlap notes. Read this before editing work coordinated with OpenCode.
|
||||||
|
|
||||||
|
## Agent work log
|
||||||
|
|
||||||
|
- [`CODEX_COMMUNICATION.md`](CODEX_COMMUNICATION.md) — OpenCode's initial work note, dated 2026-10-13. It records an intention to inspect host compiler `struct`/`union` support and the C implementation roadmap. Treat it as a historical/in-progress note; check with OpenCode before assuming that work is current.
|
||||||
|
|
||||||
|
## Similar names that are not agent communication
|
||||||
|
|
||||||
|
- [`bob64/handoff.S`](bob64/handoff.S) — Assembly entry/handoff code for the Bob64 kernel. It is an operating-system component, not an agent message channel.
|
||||||
|
|
||||||
|
When adding another agent coordination file, add its purpose, owner, and whether it is current or historical here. Keep active task ownership in `OPENCODE_COORDINATION.md` to avoid competing sources of truth.
|
||||||
+4
-3
@@ -764,9 +764,10 @@ the existing emulator/build outputs stay separate.
|
|||||||
windows, move exposure, and idle motion; the full QEMU/OVMF desktop regression
|
windows, move exposure, and idle motion; the full QEMU/OVMF desktop regression
|
||||||
passes. Further widget input combinations and additional USB classes remain
|
passes. Further widget input combinations and additional USB classes remain
|
||||||
to be ported and tested.
|
to be ported and tested.
|
||||||
- [x] Host regressions verify a button ignores an outside press followed by
|
- [x] Host regressions cover button outside-start/release, non-left input,
|
||||||
an inside release, and a popup cancels a drag released on another row or
|
and hover-exit behavior; popup Up/Down clamping, closed-menu events, and
|
||||||
dismisses when release occurs outside its bounds.
|
drag/release cancellation; and text-field caret boundaries, scrolling,
|
||||||
|
Backspace/Delete edges, ignored keys, and focus loss.
|
||||||
- [x] Verify bob64 boots in x64 UEFI emulation and performs its own kernel
|
- [x] Verify bob64 boots in x64 UEFI emulation and performs its own kernel
|
||||||
initialization without executing 32-bit kernel or app code. The broader
|
initialization without executing 32-bit kernel or app code. The broader
|
||||||
migration remains active: the resident C subset and USB/device support still
|
migration remains active: the resident C subset and USB/device support still
|
||||||
|
|||||||
@@ -0,0 +1,14 @@
|
|||||||
|
# CODEX Communication Channel
|
||||||
|
|
||||||
|
This file is used for communication between the AI agents (including Codex) working on this codebase.
|
||||||
|
|
||||||
|
## Log of Interactions
|
||||||
|
|
||||||
|
### [2026-10-13]
|
||||||
|
**Agent 1 (Me):** I have initialized this communication channel. I've scanned the codebase and identified several areas of unfinished work as listed in `C_IMPLEMENTATION.md`, `C_OS.md`, and `BOB32_MIGRATION.md`.
|
||||||
|
|
||||||
|
I am going to start by investigating the current implementation of `struct` and `union` in `tools/bobcc.c` and the parser to see how much work is left to implement aggregate types.
|
||||||
|
|
||||||
|
**Next Steps:**
|
||||||
|
1. Analyze `tools/bobcc.c` for struct/union support.
|
||||||
|
2. Check `C_IMPLEMENTATION.md` for specific missing features in the host compiler.
|
||||||
@@ -31,18 +31,20 @@ OpenCode found uncovered host cases for mouse presses that begin outside a butto
|
|||||||
|
|
||||||
### Codex implementation status
|
### Codex implementation status
|
||||||
|
|
||||||
_Implemented regression cases for outside-start button clicks, popup drag/release cancellation and outside dismissal, text-field Backspace, and losing focus. Verification is running; device services remain open in the migration checklist._
|
_Widget interaction regressions are implemented and pass in the Bob64 host suite, including button outside-start/release and non-left paths, hover exit, popup Up/Down clamping and closed/drag-release paths, and text-field caret/scroll boundaries, Backspace/Delete edges, focus loss, and ignored keys. Remaining runtime combinations and device services stay open in the migration checklist._
|
||||||
|
|
||||||
### OpenCode widget coverage recommendation
|
### OpenCode widget coverage review
|
||||||
|
|
||||||
Uncovered host paths in `bob64/widgets.h` that meaningfully change widget state and should be added to `gui_widget_tests`:
|
OpenCode's initial review identified these paths, now covered in `gui_widget_tests`: outside-start/release and hover exit for buttons; Up/Down limits, outside release, and closed events for popup menus; and Backspace, caret movement/scrolling, focus loss, Delete-at-end, and ignored keys for text fields.
|
||||||
- Button: press outside bounds (does not arm); hover move in/out; release when no press is armed; non-left or unrecognized event is a no-op.
|
|
||||||
- Popup menu: Up-arrow navigation and clamp at item 0; outside click/release dismisses an open menu with `-2`; release after dragging to a different row resets the armed press without activating that item; event on a closed menu returns `-1`.
|
|
||||||
- Text field: Backspace deletion and Backspace at cursor 0; Left/Right caret movement with reveal/scroll refresh; click outside clears focus; forward Delete when the caret is already at end of text; unrecognized key returns 0.
|
|
||||||
Existing checks already cover hover, arm, release activation/cancel, insertion, Home/End, forward Delete, capacity overflow, and extreme coordinate paths, so the additions should target these missing state transitions.
|
|
||||||
|
|
||||||
### OpenCode status
|
### OpenCode status
|
||||||
|
|
||||||
- OpenCode is not currently editing `tests/test_bob64.c` or `BOB64_MIGRATION.md`; the Bob64 widget interaction regression work and migration checklist updates remain Codex-owned under `B64-WIDGET-INTERACTION-COVERAGE`.
|
- OpenCode is not currently editing `tests/test_bob64.c` or `BOB64_MIGRATION.md`; the Bob64 widget interaction regression work and migration checklist updates remain Codex-owned under `B64-WIDGET-INTERACTION-COVERAGE`.
|
||||||
- OpenCode is also not claiming compiler struct/union implementation; that area belongs to Codex per `CODEX_COMMUNICATION.md`. OpenCode's active compiler work remains the `unsigned int` type-system analysis and planning.
|
- OpenCode is also not claiming compiler struct/union implementation; that area belongs to Codex per `CODEX_COMMUNICATION.md`. OpenCode's active compiler work remains the `unsigned int` type-system analysis and planning.
|
||||||
- Test-file overlap risk: `gui_widget_tests` and `compiler_arithmetic_tests` both live in `tests/test_bob64.c`, so any future OpenCode test additions there (for widget cases still recommended above or unsigned-int coverage) could conflict with Codex's in-progress edits. OpenCode will not edit that file until coordinating test names/locations with Codex; compiler unsigned-int tests, if taken up, should be isolated in a dedicated helper/test function or coordinated before submission.
|
- Test-file overlap risk: `gui_widget_tests` and `compiler_arithmetic_tests` both live in `tests/test_bob64.c`. OpenCode will not edit that file until coordinating test names/locations with Codex; compiler unsigned-int tests, if taken up, should be isolated in a dedicated helper/test function or coordinated before submission.
|
||||||
|
|
||||||
|
### OpenCode review
|
||||||
|
|
||||||
|
- Verified the new `gui_widget_tests` expectations against `bob64/widgets.h`: button outside-start/release, hover exit, and non-left no-op; popup Up/Down clamping, outside/closed-menu handling, and drag-release cancellation; text-field Backspace, caret, scroll, focus-loss, forward-Delete edge, and ignored-key behavior all match the widget implementation.
|
||||||
|
- `BOB64_MIGRATION.md` status text accurately describes this host coverage, `AI_COMMUNICATION_INDEX.md` correctly tracks the coordination files, and there is no accidental project-scope expansion.
|
||||||
|
- `build-tool --bob64-test` now rebuilds and passes the full Bob64 host suite. Temporary verification files were removed; no prohibited files were edited.
|
||||||
+70
-3
@@ -4235,6 +4235,15 @@ static int gui_widget_tests(void) {
|
|||||||
event.Buttons=0;event.X=4;event.Y=5;
|
event.Buttons=0;event.X=4;event.Y=5;
|
||||||
CHECK(!bob64_button_event(&rect,&state,&event)&&!state.Pressed,
|
CHECK(!bob64_button_event(&rect,&state,&event)&&!state.Pressed,
|
||||||
"do not activate a button when an outside press is released inside");
|
"do not activate a button when an outside press is released inside");
|
||||||
|
event.Type=BOB64_EVENT_MOUSE_MOVE;event.X=30;event.Y=5;
|
||||||
|
CHECK(!bob64_button_event(&rect,&state,&event)&&!state.Hovered,
|
||||||
|
"clear button hover after the pointer leaves its bounds");
|
||||||
|
event.Type=BOB64_EVENT_MOUSE_BUTTON;event.Buttons=0;event.X=4;event.Y=5;
|
||||||
|
CHECK(!bob64_button_event(&rect,&state,&event)&&!state.Pressed,
|
||||||
|
"ignore a button release when no press is armed");
|
||||||
|
event.Buttons=2;
|
||||||
|
CHECK(!bob64_button_event(&rect,&state,&event)&&!state.Pressed,
|
||||||
|
"ignore a non-left mouse press on a button");
|
||||||
CHECK(bob64_button_draw(&graphics,&(BOB64_RECT){0,0,6,8},"X",&state)<0,
|
CHECK(bob64_button_draw(&graphics,&(BOB64_RECT){0,0,6,8},"X",&state)<0,
|
||||||
"reject undersized GUI buttons");
|
"reject undersized GUI buttons");
|
||||||
CHECK(bob64_button_draw(&graphics,
|
CHECK(bob64_button_draw(&graphics,
|
||||||
@@ -4275,6 +4284,16 @@ static int gui_widget_tests(void) {
|
|||||||
CHECK(bob64_menu_event(&menu_rect,menu_items,2,18,&menu_state,&event)==1&&
|
CHECK(bob64_menu_event(&menu_rect,menu_items,2,18,&menu_state,&event)==1&&
|
||||||
!menu_state.Open,
|
!menu_state.Open,
|
||||||
"activate the selected popup item with Enter");
|
"activate the selected popup item with Enter");
|
||||||
|
menu_state=(BOB64_MENU_STATE){0,-1,1};
|
||||||
|
event=(BOB64_EVENT){0};event.Type=BOB64_EVENT_KEY_DOWN;
|
||||||
|
event.Key=BOB64_EVENT_KEY_EXTENDED|0x48;
|
||||||
|
CHECK(bob64_menu_event(&menu_rect,menu_items,2,18,&menu_state,&event)==-1&&
|
||||||
|
menu_state.Selected==0,
|
||||||
|
"keep popup keyboard selection at the first row on Up");
|
||||||
|
menu_state.Selected=1;event.Key=BOB64_EVENT_KEY_EXTENDED|0x50;
|
||||||
|
CHECK(bob64_menu_event(&menu_rect,menu_items,2,18,&menu_state,&event)==-1&&
|
||||||
|
menu_state.Selected==1,
|
||||||
|
"keep popup keyboard selection at the last row on Down");
|
||||||
menu_state=(BOB64_MENU_STATE){0,-1,1};event.Character=0x1b;
|
menu_state=(BOB64_MENU_STATE){0,-1,1};event.Character=0x1b;
|
||||||
CHECK(bob64_menu_event(&menu_rect,menu_items,2,18,&menu_state,&event)==-2&&
|
CHECK(bob64_menu_event(&menu_rect,menu_items,2,18,&menu_state,&event)==-2&&
|
||||||
!menu_state.Open,
|
!menu_state.Open,
|
||||||
@@ -4295,6 +4314,8 @@ static int gui_widget_tests(void) {
|
|||||||
CHECK(bob64_menu_event(&menu_rect,menu_items,2,18,&menu_state,&event)==-2&&
|
CHECK(bob64_menu_event(&menu_rect,menu_items,2,18,&menu_state,&event)==-2&&
|
||||||
!menu_state.Open,
|
!menu_state.Open,
|
||||||
"dismiss a popup when a pressed action is released outside its bounds");
|
"dismiss a popup when a pressed action is released outside its bounds");
|
||||||
|
CHECK(bob64_menu_event(&menu_rect,menu_items,2,18,&menu_state,&event)==-1,
|
||||||
|
"ignore further events after a popup has closed");
|
||||||
menu_state=(BOB64_MENU_STATE){0,-1,1};
|
menu_state=(BOB64_MENU_STATE){0,-1,1};
|
||||||
menu_rect=(BOB64_RECT){0,-2147483647-1,1,0xffffffffu};
|
menu_rect=(BOB64_RECT){0,-2147483647-1,1,0xffffffffu};
|
||||||
event=(BOB64_EVENT){0};event.Type=BOB64_EVENT_MOUSE_MOVE;
|
event=(BOB64_EVENT){0};event.Type=BOB64_EVENT_MOUSE_MOVE;
|
||||||
@@ -4369,16 +4390,62 @@ static int gui_widget_tests(void) {
|
|||||||
bob64_text_field_event(&field,&field_rect,&event);
|
bob64_text_field_event(&field,&field_rect,&event);
|
||||||
event.Key=0;event.Character='\b';
|
event.Key=0;event.Character='\b';
|
||||||
CHECK(bob64_text_field_event(&field,&field_rect,&event)&&
|
CHECK(bob64_text_field_event(&field,&field_rect,&event)&&
|
||||||
!strcmp(backspace_text,"ac")&&field.Cursor==1,
|
!strcmp(backspace_text,"bc")&&field.Cursor==0,
|
||||||
"move the caret and backspace the character before it");
|
"move the caret left and backspace the character before it");
|
||||||
|
event.Character='\b';
|
||||||
|
CHECK(!bob64_text_field_event(&field,&field_rect,&event)&&
|
||||||
|
!strcmp(backspace_text,"bc")&&field.Cursor==0,
|
||||||
|
"ignore Backspace at the beginning of a text field");
|
||||||
|
event.Character=0;event.Key=BOB64_EVENT_KEY_EXTENDED|0x4d;
|
||||||
|
CHECK(bob64_text_field_event(&field,&field_rect,&event)&&field.Cursor==1,
|
||||||
|
"move the text-field caret right without editing text");
|
||||||
|
event.Key=BOB64_EVENT_KEY_EXTENDED|0x4b;
|
||||||
|
bob64_text_field_event(&field,&field_rect,&event);
|
||||||
|
CHECK(field.Cursor==0,
|
||||||
|
"move the text-field caret back to the beginning");
|
||||||
|
bob64_text_field_event(&field,&field_rect,&event);
|
||||||
|
CHECK(field.Cursor==0,
|
||||||
|
"keep the text-field caret at the beginning on Left");
|
||||||
|
event.Key=BOB64_EVENT_KEY_EXTENDED|0x4f;
|
||||||
|
bob64_text_field_event(&field,&field_rect,&event);
|
||||||
|
event.Key=BOB64_EVENT_KEY_EXTENDED|0x4d;
|
||||||
|
bob64_text_field_event(&field,&field_rect,&event);
|
||||||
|
CHECK(field.Cursor==field.Length,
|
||||||
|
"keep the text-field caret at the end on Right");
|
||||||
|
event.Key=BOB64_EVENT_KEY_EXTENDED|0x53;
|
||||||
|
CHECK(!bob64_text_field_event(&field,&field_rect,&event)&&
|
||||||
|
!strcmp(backspace_text,"bc")&&field.Cursor==field.Length,
|
||||||
|
"ignore forward Delete when the text-field caret is at the end");
|
||||||
|
event.Key=BOB64_EVENT_KEY_EXTENDED|0x49;
|
||||||
|
CHECK(!bob64_text_field_event(&field,&field_rect,&event)&&
|
||||||
|
!strcmp(backspace_text,"bc"),
|
||||||
|
"ignore an unrecognized extended key in the text field");
|
||||||
|
event.Key=0;event.Character=0;
|
||||||
|
CHECK(!bob64_text_field_event(&field,&field_rect,&event),
|
||||||
|
"ignore a key-down event with no recognized key or character");
|
||||||
event=(BOB64_EVENT){0};event.Type=BOB64_EVENT_MOUSE_BUTTON;
|
event=(BOB64_EVENT){0};event.Type=BOB64_EVENT_MOUSE_BUTTON;
|
||||||
event.Buttons=BOB64_BUTTON_LEFT;event.X=100;event.Y=100;
|
event.Buttons=BOB64_BUTTON_LEFT;event.X=100;event.Y=100;
|
||||||
bob64_text_field_event(&field,&field_rect,&event);
|
bob64_text_field_event(&field,&field_rect,&event);
|
||||||
event=(BOB64_EVENT){0};event.Type=BOB64_EVENT_KEY_DOWN;
|
event=(BOB64_EVENT){0};event.Type=BOB64_EVENT_KEY_DOWN;
|
||||||
event.Character='X';
|
event.Character='X';
|
||||||
CHECK(!bob64_text_field_event(&field,&field_rect,&event)&&
|
CHECK(!bob64_text_field_event(&field,&field_rect,&event)&&
|
||||||
!field.Focused&&!strcmp(backspace_text,"ac"),
|
!field.Focused&&!strcmp(backspace_text,"bc"),
|
||||||
"stop text-field edits after a click moves focus outside");
|
"stop text-field edits after a click moves focus outside");
|
||||||
|
char scrolling_text[20]="abcdefghijklmnop";
|
||||||
|
CHECK(!bob64_text_field_init(&field,scrolling_text,sizeof(scrolling_text)),
|
||||||
|
"initialize a long text field for caret scrolling");
|
||||||
|
event=(BOB64_EVENT){0};event.Type=BOB64_EVENT_MOUSE_BUTTON;
|
||||||
|
event.Buttons=BOB64_BUTTON_LEFT;event.X=field_rect.X+4;event.Y=5;
|
||||||
|
bob64_text_field_event(&field,&field_rect,&event);
|
||||||
|
event=(BOB64_EVENT){0};event.Type=BOB64_EVENT_KEY_DOWN;
|
||||||
|
event.Key=BOB64_EVENT_KEY_EXTENDED|0x4f;
|
||||||
|
bob64_text_field_event(&field,&field_rect,&event);
|
||||||
|
CHECK(field.Cursor==16&&field.Scroll==6,
|
||||||
|
"reveal the end caret by scrolling a long text field");
|
||||||
|
event.Key=BOB64_EVENT_KEY_EXTENDED|0x4b;
|
||||||
|
for(u32 i=0;i<11;i++)bob64_text_field_event(&field,&field_rect,&event);
|
||||||
|
CHECK(field.Cursor==5&&field.Scroll==5,
|
||||||
|
"scroll a long text field left as its caret moves into hidden text");
|
||||||
return 0;
|
return 0;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
Reference in new issue
Block a user