fastfetch-cli/fastfetch
1
0
Fork 0
mirror of https://github.com/fastfetch-cli/fastfetch.git synced 2026-10-31 10:02:49 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Sound: always initialize identifier and destroy it to avoid memleaks

Browse Source
This commit is contained in:
李通洲
2023-01-28 13:45:24 +08:00
parent 1c38ebb551
commit f4cefe955b
4 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/detection/sound/sound.h
+1 -1
View File
@@ -7,7 +7,7 @@
typedef struct FFSoundDevice
{
FFstrbuf identifier; // Used internally, not guaranteed to be initialized
FFstrbuf identifier;
FFstrbuf name;
FFstrbuf manufacturer;
uint8_t volume; // 0-100%
src/detection/sound/sound_apple.c
+1
View File
@@ -40,6 +40,7 @@ const char* ffDetectSound(FF_MAYBE_UNUSED const FFinstance* instance, FFlist* de
device->main = deviceId == mainDeviceId;
device->active = device->main;
device->volume = 0;
ffStrbufInitF(&device->identifier, "%u", (unsigned) deviceId);
ffStrbufInit(&device->name);
ffStrbufInit(&device->manufacturer);
src/detection/sound/sound_windows.cpp
+3
View File
@@ -63,9 +63,12 @@ const char* ffDetectSound(FF_MAYBE_UNUSED const FFinstance* instance, FF_MAYBE_U
device->main = wcscmp(mainDeviceId, immDeviceId) == 0;
device->active = !!(immState & DEVICE_STATE_ACTIVE);
device->volume = 0;
ffStrbufInit(&device->identifier);
ffStrbufInit(&device->name);
ffStrbufInit(&device->manufacturer);
ffStrbufSetWS(&device->identifier, immDeviceId);
{
PROPVARIANT __attribute__((__cleanup__(PropVariantClear))) friendlyName;
PropVariantInit(&friendlyName);