From f0759acd118a746433c8565239e90a55ccaff825 Mon Sep 17 00:00:00 2001 From: Carter Li Date: Sat, 18 Oct 2025 09:35:34 +0800 Subject: [PATCH] Brightness (macOS): tidy --- src/detection/brightness/brightness_apple.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/src/detection/brightness/brightness_apple.c b/src/detection/brightness/brightness_apple.c index 3b5116e58..a6a77b2af 100644 --- a/src/detection/brightness/brightness_apple.c +++ b/src/detection/brightness/brightness_apple.c @@ -123,11 +123,12 @@ static const char* detectWithDdcci(FF_MAYBE_UNUSED const FFDisplayServerResult* return NULL; } #else -static IOOptionBits getSupportedTransactionType(void) { +static IOOptionBits getSupportedTransactionType(void) +{ FF_IOOBJECT_AUTO_RELEASE io_iterator_t iterator = IO_OBJECT_NULL; if (IOServiceGetMatchingServices(MACH_PORT_NULL, IOServiceNameMatching("IOFramebufferI2CInterface"), &iterator) != KERN_SUCCESS) - return 0; + return kIOI2CNoTransactionType; io_registry_entry_t registryEntry; while ((registryEntry = IOIteratorNext(iterator)) != MACH_PORT_NULL) @@ -145,22 +146,20 @@ static IOOptionBits getSupportedTransactionType(void) { return kIOI2CDDCciReplyTransactionType; if ((1 << kIOI2CSimpleTransactionType) & (uint64_t) types) return kIOI2CSimpleTransactionType; - if ((1 << kIOI2CCombinedTransactionType) & (uint64_t) types) - return kIOI2CCombinedTransactionType; - if ((1 << kIOI2CDisplayPortNativeTransactionType) & (uint64_t) types) - return kIOI2CDisplayPortNativeTransactionType; } } break; } - return 0; + return kIOI2CNoTransactionType; } static const char* detectWithDdcci(const FFDisplayServerResult* displayServer, FFBrightnessOptions* options, FFlist* result) { if (!CGSServiceForDisplayNumber) return "CGSServiceForDisplayNumber is not available"; IOOptionBits transactionType = getSupportedTransactionType(); + if (transactionType == kIOI2CNoTransactionType) + return "No supported IOI2C transaction type found"; FF_LIST_FOR_EACH(FFDisplayResult, display, displayServer->displays) {