From ed2b72e0cff0d8b9db0601165f65f9177f8a967b Mon Sep 17 00:00:00 2001 From: Linus Dierheimer Date: Sun, 9 May 2021 12:39:44 +0200 Subject: [PATCH] fixed unnecessary format string evaluation in ffPrintError --- src/common/io.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/common/io.c b/src/common/io.c index 54725f681..81af2f29f 100644 --- a/src/common/io.c +++ b/src/common/io.c @@ -39,10 +39,13 @@ void ffPrintLogoAndKey(FFinstance* instance, const char* moduleName, uint8_t mod void ffPrintError(FFinstance* instance, const char* moduleName, uint8_t moduleIndex, const FFstrbuf* customKeyFormat, const FFstrbuf* formatString, uint32_t numFormatArgs, const char* message, ...) { + if(!instance->config.showErrors) + return; + va_list arguments; va_start(arguments, message); - if((formatString == NULL || formatString->length == 0) && instance->config.showErrors) + if(formatString == NULL || formatString->length == 0) { ffPrintLogoAndKey(instance, moduleName, moduleIndex, customKeyFormat); fputs(FASTFETCH_TEXT_MODIFIER_ERROR, stdout);