From 4b4f92eb741b4896e44f0f4c523d9cf4e6d66f99 Mon Sep 17 00:00:00 2001
From: Linus Dierheimer <Linus@Dierheimer.de>
Date: Mon, 22 Feb 2021 17:14:46 +0100
Subject: [PATCH] fixed some compiler warnings

---
 CMakeLists.txt  |  2 ++
 src/fastfetch.c | 11 +++++++++--
 src/font.c      |  2 +-
 src/host.c      |  2 +-
 src/terminal.c  |  2 +-
 5 files changed, 14 insertions(+), 5 deletions(-)

diff --git a/CMakeLists.txt b/CMakeLists.txt
index fc7707313..bb87a9df6 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -4,6 +4,8 @@ project(fastfetch)
 
 include (${CMAKE_ROOT}/Modules/FindX11.cmake)
 
+set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wall")
+
 add_executable(fastfetch
     src/fastfetch.c
     src/break.c
diff --git a/src/fastfetch.c b/src/fastfetch.c
index 8184ab3aa..5a4405534 100644
--- a/src/fastfetch.c
+++ b/src/fastfetch.c
@@ -103,7 +103,7 @@ void ffPrintError(FFstate* state, const char* key, const char* message)
     printf(FASTFETCH_TEXT_MODIFIER_ERROR"%s\n"FASTFETCH_TEXT_MODIFIER_RESET, message);
 }
 
-static bool getCacheFileName(FFstate* state, const char* key, char* buffer)
+static void getCacheFileName(FFstate* state, const char* key, char* buffer)
 {
     const char* xdgCache = getenv("XDG_CACHE_HOME");
     if(xdgCache == NULL)
@@ -146,6 +146,8 @@ bool ffPrintCachedValue(FFstate* state, const char* key)
 
     ffPrintLogoAndKey(state, key);
     puts(value);
+
+    return true;
 }
 
 void ffSaveCachedValue(FFstate* state, const char* key, const char* value)
@@ -157,9 +159,14 @@ void ffSaveCachedValue(FFstate* state, const char* key, const char* value)
     if(fd == -1)
         return;
 
-    write(fd, value, strlen(value));
+    size_t len = strlen(value);
+
+    bool failed = write(fd, value, len) != len;
 
     close(fd);
+
+    if(failed)
+        unlink(fileName);
 }
 
 static void printHelp()
diff --git a/src/font.c b/src/font.c
index 9b321f010..a5cbc0a50 100644
--- a/src/font.c
+++ b/src/font.c
@@ -35,7 +35,7 @@ void ffPrintFont(FFstate* state)
     
     char gtk3Pretty[256];
     if(gtk3[0] == '\0')
-        gtk3Pretty[0]== '\0';
+        gtk3Pretty[0] = '\0';
     else
         parseFont(gtk3, gtk3Pretty);
 
diff --git a/src/host.c b/src/host.c
index df110d890..e6c26606a 100644
--- a/src/host.c
+++ b/src/host.c
@@ -27,7 +27,7 @@ void ffPrintHost(FFstate* state)
     {
         ssize_t len = strlen(host);
         host[len] = ' ';
-        fscanf(versionFile, "%[^\n]", host + len + 1);
+        if(fscanf(versionFile, "%[^\n]", host + len + 1) == 0); //fail silently, if reading of version fails, just show now version
         fclose(versionFile);
     }
 
diff --git a/src/terminal.c b/src/terminal.c
index 3677cc80e..164408f23 100644
--- a/src/terminal.c
+++ b/src/terminal.c
@@ -10,7 +10,7 @@ void printTerminalName(FFstate* state, const char* pid)
     FILE* stat = fopen(file, "r");
     if(stat == NULL)
     {
-        char error[256];
+        char error[300];
         sprintf(error, "fopen(\"%s\", \"r\") == NULL", file);
         ffPrintError(state, "Terminal", error);
         return;