From 26b3a84b8afc6b76e2ccab4403878a85ef72f224 Mon Sep 17 00:00:00 2001 From: Carter Li Date: Mon, 11 May 2026 08:51:41 +0800 Subject: [PATCH] Terminal: fixes TDE konsole version detection Fixes #2319 --- CHANGELOG.md | 3 ++- src/detection/terminalshell/terminalshell.c | 6 +++++- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 40353b73a..8aed4586b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -18,11 +18,12 @@ Bugfixes: * Improves Wi-Fi reliability on Linux by switching to a netlink implementation (Wifi, Linux) * Improves network interface reliability and default route selection on macOS and Windows (Netif, macOS / Windows) * Validates temperature color thresholds as integers when parsing JSON config (Temps) -* Fixes GNOME OS builtin logo detection (#2296) +* Fixes TDE konsole version detection (#2319, Terminal, Linux) * Various internal cleanups and optimizations Logos: * Adds KibaOS and NebiOS +* Fixes GNOME OS builtin logo detection (#2296) * Removes Ubuntu KDE # 2.62.1 diff --git a/src/detection/terminalshell/terminalshell.c b/src/detection/terminalshell/terminalshell.c index c02cc6c46..10f365cfc 100644 --- a/src/detection/terminalshell/terminalshell.c +++ b/src/detection/terminalshell/terminalshell.c @@ -365,7 +365,11 @@ FF_A_UNUSED static bool getTerminalVersionKonsole(FFstrbuf* exe, FFstrbuf* versi } } - return getExeVersionGeneral(exe, version); + // Likely TDE konsole. See #2319 + if (!getExeVersionRaw(exe, version)) { + return false; + } + return ffStrbufSubstrAfterLastC(version, ' '); } FF_A_UNUSED static bool getTerminalVersionFoot(FFstrbuf* exe, FFstrbuf* version) {