From 587d0108d48952dd4e1ad2ef46777c5dea44a449 Mon Sep 17 00:00:00 2001
From: MickLesk <47820557+MickLesk@users.noreply.github.com>
Date: Tue, 3 Nov 2026 10:45:53 +0100
Subject: [PATCH] OPNsense VM: say why the EFI disk could not be allocated

pvesm's error went to stderr only, so the two exit 220 runs in telemetry
carry no reason. As msg_error it reaches the log and the trace, e.g.
"disk image '.../vm-969-disk-0.qcow2' already exists" after an earlier
run left its disk on a storage that qm destroy does not clean.
---
 vm/opnsense-vm.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/vm/opnsense-vm.sh b/vm/opnsense-vm.sh
index 5abe90132..a6c747796 100644
--- a/vm/opnsense-vm.sh
+++ b/vm/opnsense-vm.sh
@@ -411,7 +411,7 @@ while :; do
     alloc_delay=$((alloc_delay * 2))
     continue
   fi
-  echo -e "$alloc_err" >&2
+  msg_error "Could not allocate the EFI disk on ${STORAGE}: ${alloc_err}"
   exit 220
 done
 vm_import_disk "$VMID" "$FILE" "$STORAGE"